Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added registry functionality to allow notification to have a logo #75

Merged
merged 10 commits into from
Dec 16, 2024
Merged

Added registry functionality to allow notification to have a logo #75

merged 10 commits into from
Dec 16, 2024

Conversation

Rodvdc
Copy link
Collaborator

@Rodvdc Rodvdc commented Dec 13, 2024 •
edited by dhruvan2006
Loading

  • Added registry method for first setup to register TUEnroll as an app
  • Disclaimer: repository needs to be public for the image to be downloaded correctly

Closes #43

@Rodvdc Rodvdc force-pushed the feature/logo-notifications branch 3 times, most recently from 22ee172 to e6acdd1 Compare December 14, 2024 09:53
dhruvan2006
dhruvan2006 requested changes Dec 14, 2024
View reviewed changes
Copy link
Owner

@dhruvan2006 dhruvan2006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically add some tests

src/registry.rs Outdated Show resolved Hide resolved
src/main.rs Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
dhruvan2006
dhruvan2006 reviewed Dec 14, 2024
View reviewed changes
src/main.rs Outdated Show resolved Hide resolved
@dhruvan2006
Copy link
Owner

Dark mode:
image

Light mode:
image

@Rodvdc Rodvdc force-pushed the feature/logo-notifications branch from bc9c090 to 2a29874 Compare December 16, 2024 21:46
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/main.rs 0.00% 20 Missing ⚠️
src/registry.rs 0.00% 9 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files with missing lines Coverage Δ
src/registry.rs 0.00% <0.00%> (ø)
src/main.rs 23.96% <0.00%> (-2.17%) ⬇️

@dhruvan2006 dhruvan2006 merged commit 77cf6ca into main Dec 16, 2024
3 checks passed
@dhruvan2006 dhruvan2006 deleted the feature/logo-notifications branch December 16, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvan2006 dhruvan2006 dhruvan2006 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add custom app name & icon to windows notifications
3 participants
@Rodvdc @dhruvan2006 @codecov-commenter